missing step argument and improvements for Number Controllers #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 19, 2014 13:51
step argument was not provided in factory.js
adds the ability to change the value in the Number box while the controller is listening via .listen(). Prevents the slider bar from being wider than than 100%.
dionysiusmarquis
changed the title
This was referenced Mar 18, 2016
Closed
|
Please merge this @doug, if you don't have time then I guess we need more maintainers on this project. It's a great project so I hate to see it in a coma |
|
Thanks! This fix has been merged into develop 91272ed and will make it to master ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add(…).min().max().step() does not work for me. For testing purpose use
a starting value of 0. add() will return the NumberControllerSlider and
the following function calls min() max() step() won’t reach the
corresponding NumberControllerBox.
For the shorthand call add(…, min, max, step) was the step argument
missing in the factory.js. This merge request will fix this but the
other bug remains (also see #45).
I Also added some improvements for the Number Controllers in my second commit:
-adds the ability to change the value in the Number box while the controller is listening via .listen().
-Prevents the slider bar from being wider than than 100%.
I'm not sure if document.activeElement.blur() is proper, but it does the trick.