Debounce onResize to avoid performance issues #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes terrible performance issues on IOS 8 Safari
…the old bad default for now
…, falling back to the old bad default for now
…, falling back to the old bad default for now. Plus docs on building.
customlogic
added a commit
that referenced
this pull request
Aug 18, 2016
|
Thanks for your help. I've incorporated your change, with a few tweaks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only really had trouble on IOS 8 Safari, where onResize could fire so much it blocked the whole browser for a full minute on a simple orientation change.
Either way, should not need to fire that often, so we debounce it by 1 second.
Pull request also contains rebuilt distribution files with this change.