support ArrowDataType::Utf8View.

databendlabs · Nov 12, 2024 · 5c5efad · 5c5efad
1 parent 5aaad97
commit 5c5efad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/sql/src/schema.rs b/sql/src/schema.rs
@@ -333,7 +333,9 @@ impl TryFrom<&Arc<ArrowField>> for Field {
                 ArrowDataType::Binary
                 | ArrowDataType::LargeBinary
                 | ArrowDataType::FixedSizeBinary(_) => DataType::Binary,
-                ArrowDataType::Utf8 | ArrowDataType::LargeUtf8 => DataType::String,
+                ArrowDataType::Utf8 | ArrowDataType::LargeUtf8 | ArrowDataType::Utf8View => {
+                    DataType::String
+                }
                 ArrowDataType::Timestamp(_, _) => DataType::Timestamp,
                 ArrowDataType::Date32 => DataType::Date,
                 ArrowDataType::Decimal128(p, s) => {

diff --git a/sql/src/value.rs b/sql/src/value.rs
@@ -30,6 +30,7 @@ use crate::{
     schema::{DecimalDataType, DecimalSize},
 };
 
+use arrow_array::StringViewArray;
 use geozero::wkb::FromWkb;
 use geozero::wkb::WkbDialect;
 use geozero::wkt::Ewkt;
@@ -402,7 +403,10 @@ impl TryFrom<(&ArrowField, &Arc<dyn ArrowArray>, usize)> for Value {
                 Some(array) => Ok(Value::String(array.value(seq).to_string())),
                 None => Err(ConvertError::new("large string", format!("{:?}", array)).into()),
             },
-
+            ArrowDataType::Utf8View => match array.as_any().downcast_ref::<StringViewArray>() {
+                Some(array) => Ok(Value::String(array.value(seq).to_string())),
+                None => Err(ConvertError::new("string view", format!("{:?}", array)).into()),
+            },
             // we only support timestamp in microsecond in databend
             ArrowDataType::Timestamp(unit, tz) => {
                 match array.as_any().downcast_ref::<TimestampMicrosecondArray>() {