Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): http driver show error with detail. #287

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 1, 2023

@TCeason
Copy link
Collaborator

TCeason commented Nov 1, 2023

I tested this pr on my local. It's ok.

But in this issue, if under cluster mode, enable_distributed_copy_into=0, use bendsql test will also discard this line:

#git diff
-at file 'sample_2_columns.csv', line 0

So maybe this pr does not fix the root cause.

If bendsql needs detail I think we can merge it.

@youngsofun
Copy link
Member Author

youngsofun commented Nov 1, 2023

If bendsql needs detail I think we can merge it.

yes, we do

So maybe this pr does not fix the root cause

I will check it later

@everpcpc everpcpc changed the title feat: http driver show error with detail. feat(core): http driver show error with detail. Nov 2, 2023
@everpcpc everpcpc merged commit b622edd into databendlabs:main Nov 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants