Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: if return databend-query err should exit client #502

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Oct 30, 2024

Test:

in main branch:

If databend-query not start, bendsql not exit.

➜  bendsql git:(main) cargo build --bin bendsql && ./target/debug/bendsql --query='select 1'
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s
Error: APIError: RequestError: error sending request for url (http://localhost:8000/v1/query)
➜  bendsql git:(main) cargo build --bin bendsql && ./target/debug/bendsql                   
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s
Welcome to BendSQL 0.22.2-b6f550d(2024-10-30T03:05:49.669884189Z).
Connecting to localhost:8000 as user root.
Connected to 
Started web server at 127.0.0.1:8080

:) select 1;
error: APIError: RequestError: error sending request for url (http://localhost:8000/v1/query)

@TCeason TCeason requested a review from b41sh October 30, 2024 03:08
@TCeason TCeason force-pushed the err_exit branch 2 times, most recently from 8a27587 to 1c6dcca Compare October 30, 2024 03:42
@sundy-li sundy-li merged commit d1a1d29 into databendlabs:main Oct 30, 2024
7 checks passed
@sundy-li sundy-li requested a review from youngsofun October 30, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants