Skip to content

Commit

Permalink
Merge pull request #5441 from drmingdrmer/no-pool
Browse files Browse the repository at this point in the history
[meta/client] workaround: temporarily disable conn pool until cross-runtime hanging is fixed
  • Loading branch information
BohuTANG authored May 18, 2022
2 parents 75d7336 + 05d0cc6 commit 056431b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions common/base/src/containers/pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ where
}
}

pub fn item_manager(&self) -> &Mgr {
&self.manager
}

/// Return an raw pool item.
///
/// The returned one may be an uninitialized one, i.e., it contains a None.
Expand Down
6 changes: 5 additions & 1 deletion common/meta/grpc/src/grpc_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@ impl MetaGrpcClient {
if (*eps).is_empty() {
return Err(MetaError::InvalidConfig("endpoints is empty".to_string()));
}
self.conn_pool.get(&*eps).await?
// TODO(xp): use the client across runtime hangs the application.
// Temporarily disable reusing a client.
// See: https://github.com/datafuselabs/databend/runs/6367049291?check_suite_focus=true
// self.conn_pool.get(&*eps).await?
self.conn_pool.item_manager().build(&*eps).await?
};
tracing::info!("connecting with channel: {:?}", channel);

Expand Down

0 comments on commit 056431b

Please sign in to comment.