Merge pull request #5432 from zhang2014/add_comment

chore(insert): add comment
databendlabs · May 18, 2022 · 9ad8c78 · 9ad8c78
2 parents 87e5228 + f716e2c
commit 9ad8c78
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/query/src/interpreters/interpreter_insert.rs b/query/src/interpreters/interpreter_insert.rs
@@ -165,6 +165,8 @@ impl InsertInterpreter {
         let catalog_name = self.plan.catalog_name.clone();
         let context = self.ctx.clone();
         let append_entries = self.ctx.consume_precommit_blocks();
+
+        // We must put the commit operation to global runtime, which will avoid the "dispatch dropped without returning error" in tower
         let handler = self.ctx.get_storage_runtime().spawn(async move {
             table
                 .commit_insertion(context, &catalog_name, append_entries, overwrite)