fix clippy

databendlabs · Jun 1, 2022 · d9a47a3 · d9a47a3
1 parent 5811807
commit d9a47a3
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/query/src/sql/planner/binder/join.rs b/query/src/sql/planner/binder/join.rs
@@ -127,12 +127,12 @@ impl<'a> Binder {
         left_child: SExpr,
         right_child: SExpr,
     ) -> Result<SExpr> {
-        if join_type == JoinType::CrossJoin {
-            if !left_conditions.is_empty() || !right_conditions.is_empty() {
-                return Err(ErrorCode::SemanticError(
-                    "Join conditions should be empty in cross join",
-                ));
-            }
+        if join_type == JoinType::CrossJoin
+            && (!left_conditions.is_empty() || !right_conditions.is_empty())
+        {
+            return Err(ErrorCode::SemanticError(
+                "Join conditions should be empty in cross join",
+            ));
         }
         let inner_join = LogicalJoin {
             left_conditions,