Skip to content

Commit

Permalink
Merge pull request #5690 from devillove084/main
Browse files Browse the repository at this point in the history
Remove schema_api_test_suite todos
  • Loading branch information
mergify[bot] authored May 30, 2022
2 parents e49cad5 + cbe3571 commit ea6e1fc
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions common/meta/api/src/schema_api_test_suite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1224,13 +1224,7 @@ impl SchemaApiTestSuite {

let got = mt.get_table((tenant, db1_name, tb3_name).into()).await?;
let want = TableInfo {
// TODO: use this after kv-txn rename-table replaces metasrv rename-table:
// `ident: tb_ident.clone(),`
// rename-table should not change the seq.
ident: TableIdent {
table_id: tb_ident.table_id,
seq: got.ident.seq,
},
ident: tb_ident.clone(),
desc: format!("'{}'.'{}'.'{}'", tenant, db1_name, tb3_name),
name: tb3_name.into(),
meta: table_meta(created_on),
Expand Down Expand Up @@ -1363,12 +1357,7 @@ impl SchemaApiTestSuite {

let got = mt.get_table((tenant, db2_name, tb3_name).into()).await?;
let want = TableInfo {
// TODO similar: version should not change.
// ident: tb_ident2,
ident: TableIdent {
table_id: tb_ident2.table_id,
seq: got.ident.seq,
},
ident: tb_ident2,
desc: format!("'{}'.'{}'.'{}'", tenant, db2_name, tb3_name),
name: tb3_name.into(),
meta: table_meta(created_on),
Expand Down

0 comments on commit ea6e1fc

Please sign in to comment.