-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider refactory catalog trait #3098
Comments
agree with you ... they have a similar meaning and I get confused when first encountering these two trait methods |
Some initial thoughts:
In |
To my understanding, there two major pieces of information for data:
Take csv as an example, it actually defines both of these two. Maybe we need to clarify these two roles from bottom up, e.g.: |
I am trying on it:#3136 |
Summary
catalog trait is not clear, for example in
catalog
trait it has abuild_table
to return adyn Table
by table info and used by many places:In database trait, it has
get_table
to returndyn Table
by db_name and table_name and used by many places other:Goal:
The text was updated successfully, but these errors were encountered: