-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORAGE-3098: Catalog refactor #3136
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov Report
@@ Coverage Diff @@
## main #3136 +/- ##
=======================================
Coverage 66% 67%
=======================================
Files 676 750 +74
Lines 35146 38273 +3127
=======================================
+ Hits 23426 25765 +2339
- Misses 11720 12508 +788
Continue to review full report at Codecov.
|
4fbb89d
to
41602c7
Compare
dc7c5b6
to
5e8e8f5
Compare
This pull request has merge conflicts that must be resolved before it can be merged. @BohuTANG please rebase it 🙏 |
59c8317
to
1069a60
Compare
Wow~ |
/lgtm Much more clear and obvious~ |
/LGTM |
/LGTM & salute |
I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/
Summary
This patch cannot be split into many small PRs, it is easy to cause conflicts:<
Summary about this PR:
datasources
tostorages
In
storages
dir, the table engine defines:How and where data is stored, where to write it and where read from.
TODO(in another PR):
Changelog
Related Issues
Fixes #3098
Test Plan
Unit Tests
Stateless Tests