Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dal2: Implement s3 support #3774

Closed
4 tasks done
Tracked by #3677
Xuanwo opened this issue Jan 5, 2022 · 2 comments
Closed
4 tasks done
Tracked by #3677

dal2: Implement s3 support #3774

Xuanwo opened this issue Jan 5, 2022 · 2 comments
Assignees
Labels
A-storage Area: databend storage C-improvement Category: improvement

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jan 5, 2022

Part of #3677

TODO

Waiting

  • SDK needs to support path style
  • SDK needs to support signature v2
@Xuanwo Xuanwo self-assigned this Jan 5, 2022
@Xuanwo Xuanwo moved this to 🔨 In Progress in Xuanwo's Work Jan 5, 2022
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 5, 2022

not sure if the signature of method enable_path_style is composable with the finish method, e.g. builder.enable_path_style().finish()?

Originally posted by @dantengsky in #3775 (comment)

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 5, 2022

@dantengsky, I think this style works. I will add a test case for Builder to make sure they works as expected.

@BohuTANG BohuTANG added C-improvement Category: improvement A-storage Area: databend storage labels Jan 6, 2022
@Xuanwo Xuanwo moved this from 🔨 In Progress to 📋 Backlog in Xuanwo's Work Jan 17, 2022
@Xuanwo Xuanwo closed this as completed Feb 26, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 📦 Done in Xuanwo's Work Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Area: databend storage C-improvement Category: improvement
Projects
None yet
Development

No branches or pull requests

2 participants