-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dal2: Add s3 support layout #3775
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Thanks for the contribution! Please review the labels and make any necessary changes. |
1 similar comment
Thanks for the contribution! Please review the labels and make any necessary changes. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/83RzoWd4Rueff6ki5nXtbGeTFAio [Deployment for 0f902bc canceled] |
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report
@@ Coverage Diff @@
## main #3775 +/- ##
=====================================
- Coverage 59% 59% -1%
=====================================
Files 707 708 +1
Lines 38206 38235 +29
=====================================
- Hits 22814 22749 -65
- Misses 15392 15486 +94
Continue to review full report at Codecov.
|
@dantengsky @Veeupup I found iplement s3 support is more complex so I spilt it into #3774 instead. PTAL, thanks! |
tokio = { version = "1.15.0", features = ["fs"] } | ||
thiserror = "1" | ||
aws-config = "0.3.0" | ||
aws-types = {version = "0.3.0", features = ["hardcoded-credentials"]} | ||
aws-sdk-s3 = "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurrah!
/lgtm |
Wait for another reviewer approval |
CI Passed |
Signed-off-by: Xuanwo github@xuanwo.io
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Part of #3774
Changelog
Test Plan
Unit Tests
Stateless Tests