Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dal2: Add s3 support layout #3775

Merged
merged 2 commits into from
Jan 5, 2022
Merged

dal2: Add s3 support layout #3775

merged 2 commits into from
Jan 5, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 5, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Part of #3774

Changelog

  • New Feature

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from BohuTANG as a code owner January 5, 2022 06:03
@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Jan 5, 2022
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Jan 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/83RzoWd4Rueff6ki5nXtbGeTFAio
✅ Preview: Canceled

[Deployment for 0f902bc canceled]

@Xuanwo Xuanwo mentioned this pull request Jan 5, 2022
4 tasks
@Xuanwo Xuanwo requested review from dantengsky and Veeupup January 5, 2022 06:15
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #3775 (0f902bc) into main (dd7a004) will decrease coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3775   +/-   ##
=====================================
- Coverage     59%     59%   -1%     
=====================================
  Files        707     708    +1     
  Lines      38206   38235   +29     
=====================================
- Hits       22814   22749   -65     
- Misses     15392   15486   +94     
Impacted Files Coverage Δ
common/dal2/src/credential.rs 0% <0%> (ø)
common/dal2/src/services/s3.rs 0% <0%> (ø)
common/streams/src/sources/source_csv.rs 0% <0%> (-90%) ⬇️
common/streams/src/sources/source_parquet.rs 0% <0%> (-79%) ⬇️
common/functions/src/scalars/arithmetics/utils.rs 51% <0%> (-29%) ⬇️
common/dal/src/context.rs 68% <0%> (-10%) ⬇️
common/management/src/cluster/cluster_mgr.rs 78% <0%> (-3%) ⬇️
common/management/src/udf/udf_mgr.rs 88% <0%> (-1%) ⬇️
query/src/sql/statements/analyzer_expr.rs 67% <0%> (-1%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7a004...0f902bc. Read the comment docs.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 5, 2022

@dantengsky @Veeupup I found iplement s3 support is more complex so I spilt it into #3774 instead. PTAL, thanks!

tokio = { version = "1.15.0", features = ["fs"] }
thiserror = "1"
aws-config = "0.3.0"
aws-types = {version = "0.3.0", features = ["hardcoded-credentials"]}
aws-sdk-s3 = "0.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah!

@dantengsky
Copy link
Member

/lgtm

@databend-bot
Copy link
Member

Wait for another reviewer approval

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @Xuanwo

@databend-bot databend-bot merged commit 7e3ddf3 into databendlabs:main Jan 5, 2022
@Xuanwo Xuanwo deleted the dal-s3 branch January 5, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants