Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: replace FactoryCreator with FactoryCreatorWithTypes for functions #4847

Closed
zhyass opened this issue Apr 13, 2022 · 0 comments · Fixed by #4688
Closed

Improve: replace FactoryCreator with FactoryCreatorWithTypes for functions #4847

zhyass opened this issue Apr 13, 2022 · 0 comments · Fixed by #4688
Assignees
@zhyass
Labels
C-function Category: Functions C-improvement Category: improvement

Comments

@zhyass
Copy link
Member

zhyass commented Apr 13, 2022 •
edited
Loading

  1. Replace FactoryCreator with FactoryCreatorWithTypes.
  2. Rename FactoryCreatorWithTypes.
  3. New return_type in Function trait.
fn return_type(&self) -> DataTypePtr
  1. Refactor some codes in functions.
  2. Fixes bug: and or get different result in databend #4848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhyass zhyass

Labels
C-function Category: Functions C-improvement Category: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE-4847: Replace FactoryCreator with FactoryCreatorWithTypes for functions zhyass/databend
1 participant
@zhyass