Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-4847: Replace FactoryCreator with FactoryCreatorWithTypes for functions #4688

Merged
merged 15 commits into from
Apr 14, 2022

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Apr 4, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Bug Fix
  • Improvement

Related Issues

Fixes #4847
Fixes #4848

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Apr 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/GREzT1SbduTHM2vFPgjaj8DFHrNf
✅ Preview: Canceled

[Deployment for 8a62419 canceled]

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-bugfix this PR patches a bug in codebase pr-improvement labels Apr 4, 2022
@zhyass zhyass marked this pull request as draft April 4, 2022 14:55
@zhyass
Copy link
Member Author

zhyass commented Apr 4, 2022

mysql> select * from numbers(10) where null and true;
ERROR 1105 (HY000): Code: 1058, displayText = downcast column error, column type: Boolean, expected column: "common_datavalues::columns::boolean::BooleanColumn" (while in processor thread 7).

@zhyass zhyass marked this pull request as ready for review April 13, 2022 15:01
@zhyass zhyass requested a review from sundy-li April 13, 2022 15:01
@zhyass zhyass changed the title Replace FactoryCreator with FactoryCreatorWithTypes for functions ISSUE-4847: Replace FactoryCreator with FactoryCreatorWithTypes for functions Apr 13, 2022
@BohuTANG BohuTANG merged commit 0c8d96b into databendlabs:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
4 participants