Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: support setting null_string #5586

Closed
sundy-li opened this issue May 25, 2022 · 7 comments · Fixed by #6453 or databendlabs/databend-jdbc#124
Closed

Feature: support setting null_string #5586

sundy-li opened this issue May 25, 2022 · 7 comments · Fixed by #6453 or databendlabs/databend-jdbc#124
Assignees
@sundy-li @JialuGong
Labels
A-query Area: databend query C-feature Category: feature community-take good first issue Category: good first issue prio: high High priority

Comments

@sundy-li
Copy link
Member

Summary

Description for this feature.

Add a new setting named null_string, which defaults to \N.

nullable deserialization

and

nullable serialization should respect this setting
@sundy-li sundy-li added the C-feature Category: feature label May 25, 2022
@sundy-li sundy-li added A-query Area: databend query good first issue Category: good first issue labels May 25, 2022
@wubx
Copy link
Member

wubx commented May 25, 2022

I want it.

@LiuYuHui
Copy link
Contributor

I want it.

Hi @wubx , Do you want to implement it or do you just want this feature? If you just want this feature, I think I can help implement it.

@sundy-li
Copy link
Member Author

Do you want to implement it or do you just want this feature? If you just want this feature, I think I can help implement it.

I think he just wants to have this feature. It's assigned to you, good luck!

@fkuner fkuner assigned LiuYuHui and unassigned LiuYuHui May 26, 2022
@LiuYuHui LiuYuHui removed their assignment Jun 1, 2022
@JialuGong
Copy link

/assignme

@wubx
Copy link
Member

wubx commented Jun 30, 2022

Very much looking forward to this feature.
Maybe changing \N to null or NULL is a good way.

@wubx wubx mentioned this issue Jun 30, 2022
Closed
@wubx wubx added the prio: high High priority label Jul 3, 2022
@JialuGong
Copy link

@wubx I'm sorry for that I am fighting with my final exams and maybe I have no spare time to finish this issue until July 15th : (

@sundy-li
Copy link
Member Author

sundy-li commented Jul 3, 2022

I'm sorry for that I am fighting with my final exams and maybe I have no spare time to finish this issue until July 15th :

It's ok, thanks for your information, we will take it.

@sundy-li sundy-li self-assigned this Jul 3, 2022
@sundy-li sundy-li mentioned this issue Jul 5, 2022
Merged
Repository owner moved this from Todo to Done in Databend Query Engine Jul 5, 2022
@hantmac hantmac mentioned this issue Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sundy-li sundy-li

@JialuGong JialuGong

Labels
A-query Area: databend query C-feature Category: feature community-take good first issue Category: good first issue prio: high High priority
Projects
Databend Query Engine
Status: Done
Milestone
No milestone
5 participants
@wubx @sundy-li @LiuYuHui @JialuGong @databend-bot