Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix tsv deserialization #6453

Merged
merged 6 commits into from
Jul 5, 2022
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jul 5, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. TSV format will always read the escaped text to deserialize the data, so "xxxx\t123 parsed to "xxxx and 123.
  2. Fixed a bug if the text contains \\, it stopped parsing the following data.
  3. Make \N as default null representation for csv and tsv format, which fixes Feature: support setting null_string #5586
  4. Fix the bugs convert from ClickHouseBlock

TODO: parse complex escape sequence after '\'

Fixes #5586

@vercel
Copy link

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 5, 2022 at 5:34AM (UTC)

@sundy-li sundy-li requested a review from youngsofun July 5, 2022 02:28
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jul 5, 2022
@PsiACE
Copy link
Member

PsiACE commented Jul 5, 2022

after #6443 , formats is now a part of common. This PR needs to be updated.

@BohuTANG
Copy link
Member

BohuTANG commented Jul 5, 2022

Conflicting files :)

mergify bot added a commit that referenced this pull request Jul 5, 2022
@BohuTANG BohuTANG merged commit 84f7bd3 into databendlabs:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: support setting null_string
4 participants