Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support multiple table progress #8345

Closed
2 tasks
Xuanwo opened this issue Oct 20, 2022 · 3 comments · Fixed by #8363
Closed
2 tasks

Feature: Support multiple table progress #8345

Xuanwo opened this issue Oct 20, 2022 · 3 comments · Fixed by #8363
Labels
C-feature Category: feature

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Oct 20, 2022

Address #8331

Summary

We are storing dal_metrics_read_bytes, dal_metrics_write_bytes in dal_metrics_write_bytes which is shared across the whole query. This doesn't make sense now because we could have multiple tables in the same query. Users should be able to know the metrics about different tables.

Thus, we should support multiple table progress reports.

Plan

  • rename dal_metrics_read_bytes to table_data_read_bytes
  • rename dal_metrics_write_bytes to table_data_write_bytes
  • Add support for table_cache_{read/write}_bytes.
  • Init the table data metrics while creating table instances instead of query start.

Other progress like scan_progress_read_rows and scan_progress_read_bytes should also be updated.

Tasks

  • Implement single table support
  • Implement multiple table support
@BohuTANG
Copy link
Member

BohuTANG commented Oct 20, 2022

Can we get all-in-one metrics for a query? Like:

show processlist;

query_id| table_data_read_bytes: x | table_data_write_bytes: x | table_cache_read_bytes: x | table_cache_write_bytes: x

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 20, 2022

Can we get all-in-one metrics for a query? Like:

We can get all tables attached to this query and then do a simple calculation.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 20, 2022

We will start by reusing current logic first: the global metrics for current query.

@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Oct 20, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 📦 Done in Xuanwo's Work Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants