Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new window function nth_value. #11600

Merged
merged 3 commits into from
May 28, 2023
Merged

feat: new window function nth_value. #11600

merged 3 commits into from
May 28, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented May 27, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Support new window function nth_value.
  • Unify lead and lag into one structure.
  • Unify first_value, last_value and nth_value into one structure.
  • Remove useless data structures.

Tracking in #11148

@vercel
Copy link

vercel bot commented May 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) May 27, 2023 4:08am

@RinChanNOWWW RinChanNOWWW mentioned this pull request May 27, 2023
Closed
13 tasks
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 27, 2023
ariesdevil
ariesdevil approved these changes May 28, 2023
View reviewed changes
Copy link
Contributor

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariesdevil ariesdevil merged commit ceb0562 into databendlabs:main May 28, 2023
@RinChanNOWWW RinChanNOWWW deleted the window-nth-value branch May 28, 2023 07:49
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@RinChanNOWWW @andylokandy
feat: new window function nth_value. (databendlabs#11600)
a618184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariesdevil ariesdevil ariesdevil approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RinChanNOWWW @ariesdevil