Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ntile window function #11905

Merged
merged 1 commit into from
Jun 30, 2023
Merged

feat: ntile window function #11905

merged 1 commit into from
Jun 30, 2023

Conversation

ariesdevil
Copy link
Contributor

@ariesdevil ariesdevil commented Jun 28, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Impl ntile window function.

Tracking: #11148

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Jun 30, 2023 7:56am

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 28, 2023
@ariesdevil ariesdevil marked this pull request as ready for review June 29, 2023 19:18
@sundy-li sundy-li requested a review from RinChanNOWWW June 30, 2023 02:47
@ariesdevil
Copy link
Contributor Author

askbend:summary

@databend-bot
Copy link
Member

PR Summary(By llmchain.rs):

  • Add support for Ntile window function
    The changes add support for the Ntile window function in the SQL query engine. This includes adding a new variant to the WindowFunction and WindowFuncType enums, as well as implementing the function in various structs and functions.

  • Improve readability of DistributedCopyIntoTable
    The DistributedCopyIntoTable struct has been modified to add line breaks and improve readability.

  • Update longrun.py
    Variable names have been changed to follow PEP8 naming conventions, whitespace has been added for readability, f-strings have been used for string formatting, and comments have been added for clarity. A try-except block has also been added for the subprocess.Popen() call.

  • Add test cases for Ntile window function
    Test cases have been added for the Ntile window function in the window_basic.test and window_wisconsin.test files. These include tests for valid and invalid ntile() function calls.

@ariesdevil ariesdevil merged commit d22f630 into databendlabs:main Jun 30, 2023
@ariesdevil ariesdevil deleted the ntile branch June 30, 2023 10:04
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants