-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement udf server in databend #12729
Conversation
* feat: implement create and alter udf server * feat: use protobuf to serialize these UDF types * fix: fix typo * refactor: change create udf server syntax * chore: remove udf from proto_conv * fix: fix fmt
* ci: add udfserver sqllogictest * Update .github/workflows/reuse.linux.yml Co-authored-by: everpcpc <everpcpc@users.noreply.github.com> --------- Co-authored-by: everpcpc <everpcpc@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 71 files at r1, 8 of 57 files at r2, all commit messages.
Reviewable status: 11 of 72 files reviewed, all discussions resolved
I'll review the PR today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @gitccl
Currently, our Python UDF syntax is similar to snowflake:
Snowflake:
create or replace function addone(i int)
returns int
language python
runtime_version = '3.8'
handler = 'addone_py'
as
$$
def addone_py(i):
return i+1
$$;
Databend:
CREATE FUNCTION split_and_join (VARCHAR, VARCHAR, VARCHAR) RETURNS VARCHAR LANGUAGE python HANDLER = 'split_and_join' ADDRESS = 'http://0.0.0.0:8815';
Given the security concerns we discussed internally, maybe we still need to add a flag to make it a feature, so we can avoid our cloud attacking. cc @Xuanwo @flaneur2020 @BohuTANG |
cc @soyeric128 After the PR merged, need to add a doc. You can refer the README: https://github.com/datafuselabs/databend/pull/12729/files#diff-bf3534b9c183942327d5e8579cec90a1634bc242312a7cff036d80c035d11d98 |
Add a new query config is ok, then we can enable it for some users. @flaneur2020 |
It seems that ci is stuck. |
Please fix the conflicts first to make CI running, thanks! |
A flaky test cc @TCeason |
Get |
cc @gitccl |
This problem is caused by the 1.0.56 version of databend-query loading the latest configuration, but version 1.0.56 does not support the |
Currently, it's forbidden. Maybe we should fetch the old config file from git to start the old version process. |
We already use the old config files in https://github.com/datafuselabs/databend/blob/1d19af8b180b3b88f3e9eba9837d31815c9c9364/tests/compat/test-compat.sh |
test_compat_fuse use this scripts: https://github.com/datafuselabs/databend/blob/1d19af8b180b3b88f3e9eba9837d31815c9c9364/tests/fuse-compat/util.sh |
Co-authored-by: everpcpc <everpcpc@users.noreply.github.com> Co-authored-by: xudong.w <wxd963996380@gmail.com> Co-authored-by: sundy-li <543950155@qq.com>
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
This pr merges previous #12168 , #12417 and #12463 .
In this pr, we also change the syntax of
create function
command to make it similar to snowflake's syntax.This change is