-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): Need return error udf_name when derialize from pb failed. #14964
Conversation
a408790
to
223c1e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
It reverted to using prefix_list_kv() to retrieve from meta-service, that's all?
Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @sundy-li)
just return a error msg with udf_name when deserialize from pb error. Then user needs to re-create the udf. |
cc @BohuTANG How about this case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sundy-li)
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
https://github.com/datafuselabs/databend/pull/12729/files#diff-9c992028e59caebc313d761b8488b17f142618fb89db64c51c1655689d68c41b
I think we can not upgrade the old json to pb. The best way is return error udf when
select * from system.user_functions
and then user need to re-create the udf.Tests
Type of change
This change is