Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove innecessary serde #15042

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: remove innecessary serde

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues

@drmingdrmer drmingdrmer marked this pull request as ready for review March 20, 2024 07:59
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 20, 2024
@BohuTANG
Copy link
Member

error[E0277]: the trait bound `databend_common_meta_app::background::BackgroundJobParams: background_config::_::_serde::Serialize` is not satisfied
    --> src/query/config/src/background_config.rs:111:32
     |
111  | #[derive(Clone, PartialEq, Eq, Serialize, Deserialize)]
     |                                ^^^^^^^^^ the trait `background_config::_::_serde::Serialize` is not implemented for `databend_common_meta_app::background::BackgroundJobParams`
...
117  |     pub params: BackgroundJobParams,
     |     ------------------------------- required by a bound introduced by this call

@drmingdrmer
Copy link
Member Author

error[E0277]: the trait bound `databend_common_meta_app::background::BackgroundJobParams: background_config::_::_serde::Serialize` is not satisfied
    --> src/query/config/src/background_config.rs:111:32
     |
111  | #[derive(Clone, PartialEq, Eq, Serialize, Deserialize)]
     |                                ^^^^^^^^^ the trait `background_config::_::_serde::Serialize` is not implemented for `databend_common_meta_app::background::BackgroundJobParams`
...
117  |     pub params: BackgroundJobParams,
     |     ------------------------------- required by a bound introduced by this call

Well... I can see failure notification and has been fixing it, but thank you for reminding.

@BohuTANG BohuTANG merged commit 89cdf6b into databendlabs:main Mar 20, 2024
71 checks passed
@drmingdrmer drmingdrmer deleted the 38-serde-3 branch March 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants