chore(query): refactor new transform partition bucket for new aggregation hashtable #15093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
sundy-li
reviewed
Mar 26, 2024
src/query/service/src/pipelines/processors/transforms/aggregator/aggregate_exchange_injector.rs
Outdated
Show resolved
Hide resolved
sundy-li
reviewed
Mar 26, 2024
src/query/service/src/api/rpc/exchange/exchange_transform_shuffle.rs
Outdated
Show resolved
Hide resolved
Freejww
added
ci-cloud
sundy-li
force-pushed
the
fix/hits-q18-limit
branch
from
00d79b3 to
9e0e8c1
Compare
Docker Image for PR
|
Freejww
force-pushed
the
fix/hits-q18-limit
branch
from
9e0e8c1 to
1f77fad
Compare
sundy-li
approved these changes
Mar 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
…tion hashtable (databendlabs#15093) * finish new transform partition bucket for singleton * support for cluster * fix new transform partition bucket * revert * fix cluster spill bug * remove code * fix logic shortcirt bug * fix logic shortcirt bug * refactor block_number * fix block_number * fix spill hang by avoid sending empty block --------- Co-authored-by: jw <freejw@gmail.com> Co-authored-by: sundy-li <543950155@qq.com> (cherry picked from commit f8494c8)
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
In the previous #14798, we initialized all data at once for the new aggregation hashtable. This approach may have caused a performance decrease, particularly on queries such as hits-q18 (referred to as "short-circuit query").
In this PR, we introduced
new_transform_partition_bucketfor the new aggregation hashtable. We utilize a working bucket similar to the old transform_partition_bucket to handle bucket incrementally.Tests
Type of change