Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor merge into optimizer and fix unexpected distribution plan #15507

Merged
merged 7 commits into from
May 27, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented May 13, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. support explain pipeline merge into
  2. support explain fragments merge into
  3. reduce the occurrence of *distributed && !*change_join_order
  4. inner join can directly use broadcast join, don't need to add RowNumber operator
  5. reduce the complexity of merge into optimizer.
  6. improve merge into distribution plan, see the file tests/sqllogictests/suites/mode/cluster/merge_into_non_equal_distributed.test
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 marked this pull request as draft May 13, 2024 11:45
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 13, 2024
@xudong963 xudong963 force-pushed the optimizer_merge branch 3 times, most recently from d165350 to 97f2750 Compare May 24, 2024 02:07
@xudong963 xudong963 force-pushed the optimizer_merge branch 3 times, most recently from 5f4b071 to 1f8ae08 Compare May 27, 2024 06:20
@xudong963 xudong963 marked this pull request as ready for review May 27, 2024 06:23
@xudong963 xudong963 requested a review from Dousir9 May 27, 2024 06:23
@xudong963 xudong963 added this pull request to the merge queue May 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 27, 2024
@xudong963 xudong963 added this pull request to the merge queue May 27, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request May 27, 2024
@BohuTANG BohuTANG merged commit cdb2e25 into databendlabs:main May 27, 2024
75 checks passed
@xudong963 xudong963 deleted the optimizer_merge branch May 27, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants