-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: more explicit error confirmation for http query route error. #15621
Conversation
92dfc8c
to
6cd1c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it need a comprehensive test over all the drivers after api route changes, and there're also a few in-house query clients (like PHP) not using our drivers at all. if it's an enhancement over the error message, i guess we can consider a less invasive way to make it.
fb286d0
to
1958601
Compare
@flaneur2020 plz review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
also including the case that server restart (assert: always with new node_id).
we can tell it from query timeout at once.
Tests
Type of change
This change is