Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: http handler limit body size of each response to 10MB. #15960

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: http handler limit body size of each response to 10MB. #15960

merged 2 commits into from
Jul 10, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jul 3, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 3, 2024
@youngsofun youngsofun force-pushed the bodysize branch 2 times, most recently from 2bb2927 to 31367e1 Compare July 3, 2024 09:19
@youngsofun youngsofun requested review from flaneur2020, sundy-li and hantmac and removed request for flaneur2020, sundy-li and hantmac July 3, 2024 13:02
@youngsofun youngsofun enabled auto-merge July 9, 2024 14:08
flaneur2020
flaneur2020 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngsofun youngsofun added this pull request to the merge queue Jul 10, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jul 10, 2024
@BohuTANG BohuTANG merged commit 737f02e into databendlabs:main Jul 10, 2024
74 checks passed
@everpcpc everpcpc mentioned this pull request Jul 24, 2024
Closed
3 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaneur2020 flaneur2020 flaneur2020 approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngsofun @flaneur2020 @BohuTANG