Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): alter user support modify current password #15962

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jul 3, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

alter user support modify current password

Note:

  • If alter with auth_option, it should check privilege.
  • in bendsql alter current user's password will return err, because bendsql will call auth in poll, after password modified, in next poll the auth failed, it will return err. But it is not databend-query bug.
# testuser1@localhost:8000/default> alter user 'testuser1' identified by '123';
# error: APIError: RequestError: Query Page failed with status 401 Unauthorized: {"error":{"code":"401","message":"wrong password"}}

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason requested a review from b41sh July 3, 2024 09:36
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 3, 2024
@TCeason TCeason requested a review from youngsofun July 3, 2024 09:36
@TCeason TCeason marked this pull request as draft July 3, 2024 13:55
@TCeason TCeason marked this pull request as ready for review July 4, 2024 01:50
@TCeason TCeason requested a review from b41sh July 4, 2024 02:48
@BohuTANG BohuTANG merged commit 81b6b0d into databendlabs:main Jul 4, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: user can moidfy own password with out option.
4 participants