Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow tuple field name to contain '_'. #15965

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jul 3, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

this pr https://github.com/datafuselabs/databend/pull/15126/files limit it to is_ascii_alphanumeric()
but we often need '_'.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun requested a review from TCeason July 3, 2024 13:04
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 3, 2024
@youngsofun youngsofun requested a review from b41sh July 3, 2024 13:05
@TCeason
Copy link
Collaborator

TCeason commented Jul 3, 2024

LGTM but I think we should add some tests. If someone destroys this we can trigger it

@b41sh
Copy link
Member

b41sh commented Jul 3, 2024

The bug here is due to Tuple's fields_name is defined as String, resulting in missing quote-related information. We should fix this by defining fields_name as Identifier. In order to solve the problem of current use, we can merge this PR first and make further modifications later.

@youngsofun youngsofun added this pull request to the merge queue Jul 4, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jul 4, 2024
@BohuTANG BohuTANG merged commit e746d95 into databendlabs:main Jul 4, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants