Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(executor): support error profiling for cluster mode #15969

Merged
merged 4 commits into from
Jul 5, 2024
Merged

feat(executor): support error profiling for cluster mode #15969

merged 4 commits into from
Jul 5, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Jul 4, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

break changes

  • rename system.processor_profile to system.queries_profiling
  • remove pid and pname columns of system.processor_profile

feat

  • support error profiling for cluster mode

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - add profiling in other pr

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 4, 2024
@zhang2014 zhang2014 added ci-cloud Build docker image for cloud test ci-benchmark Benchmark: run all test labels Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Docker Image for PR

  • tag: pr-15969-cc72c0b-1720061814

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Docker Image for PR

  • tag: pr-15969-cc72c0b-1720062184

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

ClickBench Report

@zhang2014
Copy link
Member Author

image

@zhang2014 zhang2014 marked this pull request as ready for review July 5, 2024 02:31
@zhang2014 zhang2014 requested review from BohuTANG and dqhl76 July 5, 2024 02:31
dqhl76
dqhl76 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit e5ece50 into databendlabs:main Jul 5, 2024
75 checks passed
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqhl76 dqhl76 dqhl76 approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhang2014 @BohuTANG @dqhl76