Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): implement HAVERSINE #15971

Merged
merged 13 commits into from
Jul 5, 2024
Merged

feat(query): implement HAVERSINE #15971

merged 13 commits into from
Jul 5, 2024

Conversation

kkk25641463
Copy link
Contributor

@kkk25641463 kkk25641463 commented Jul 4, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: Implement HAVERSINE #15413

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@kkk25641463
HAVERSINE
3848c6f 
Signed-off-by: Fan Yang <yangfanlinux@gmail.com>
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 4, 2024
@kkk25641463
HAVERSINE
47db8aa 
Signed-off-by: Fan Yang <yangfanlinux@gmail.com>
@kkk25641463
Merge remote-tracking branch 'my/HAVERSINE' into HAVERSINE
f021733 
# Conflicts:
#	src/query/functions/src/scalars/geometry.rs
@b41sh b41sh self-requested a review July 4, 2024 05:43
b41sh
b41sh approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix ci tests.

@b41sh b41sh added this pull request to the merge queue Jul 5, 2024
Merged via the queue into databendlabs:main with commit 7dcd6ee Jul 5, 2024
73 checks passed
@kkk25641463 kkk25641463 deleted the HAVERSINE branch July 6, 2024 13:28
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkk25641463 @b41sh