Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add new setting enable_dst_hour_fix #16022

Merged
merged 3 commits into from
Jul 12, 2024
Merged

feat(query): add new setting enable_dst_hour_fix #16022

merged 3 commits into from
Jul 12, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jul 11, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Time conversion handles invalid DST by adding an hour. Accuracy not guaranteed.(disable by default)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 11, 2024
@TCeason
feat(query): add new setting force_timestamp_conversion
9b0e26b 
Time conversion handles invalid DST by adding an hour. Accuracy not guaranteed.(disable by default)
@TCeason TCeason requested review from youngsofun and sundy-li July 11, 2024 07:28
@TCeason TCeason changed the title feat(query): add new setting force_timestamp_conversion feat(query): add new setting enable_dst_hour_fix Jul 11, 2024
@TCeason
Copy link
Collaborator Author

TCeason commented Jul 12, 2024

cc @wubx dst fix in this pr. Please merge this pr cc @BohuTANG

@BohuTANG BohuTANG merged commit de9235c into databendlabs:main Jul 12, 2024
74 checks passed
@TCeason
Copy link
Collaborator Author

TCeason commented Jul 12, 2024

cc @soyeric128 Doc need

@TCeason TCeason mentioned this pull request Jul 18, 2024
Closed
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngsofun youngsofun youngsofun approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TCeason @sundy-li @youngsofun @BohuTANG