Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor aggregate hashtable, replace &[Column] with InputColumns #16038

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jul 12, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

follow #15991
Refactor aggregate hashtable, replace &[Column] with InputColumns

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 12, 2024
Signed-off-by: coldWater <forsaken628@gmail.com>
@forsaken628 forsaken628 changed the title feat: Refactor aggregate hashtable, replace &[Column] with InputColumns refactor: Refactor aggregate hashtable, replace &[Column] with InputColumns Jul 12, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jul 12, 2024
@sundy-li sundy-li requested a review from Freejww July 12, 2024 12:35
@Freejww Freejww added this pull request to the merge queue Jul 12, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jul 12, 2024
@BohuTANG BohuTANG merged commit e24186f into databendlabs:main Jul 12, 2024
77 checks passed
@forsaken628 forsaken628 deleted the input-col branch July 20, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants