Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function name to udf client header #16053

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Jul 15, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Centralized header definitions in src/common/base/src/headers.rs.
  • Updated UDF client to use the new header constants and improved error handling.
  • Added HEADER_FUNCTION for UDF function name information.
  • Implemented version information management in src/common/base/src/version.rs.
  • Set up a user agent string for the UDF client using the Databend version.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 15, 2024
@everpcpc everpcpc marked this pull request as ready for review July 15, 2024 08:04
@everpcpc everpcpc requested review from BohuTANG and flaneur2020 July 15, 2024 08:04
@BohuTANG BohuTANG merged commit 876b40d into databendlabs:main Jul 15, 2024
77 checks passed
@everpcpc everpcpc deleted the fix-headers branch July 15, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants