-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planner): unify execution of DML statements (MERGE, UPDATE, DELETE) #16060
feat(planner): unify execution of DML statements (MERGE, UPDATE, DELETE) #16060
Conversation
Will this refactor resolve the issue #15806? |
…atus for update and delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall migration framework and idea are as expected, most of the LGTM, but delete, update, insert execution details of the migration need to be further reviewed by the storage team. Good job!
LGTM. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the previous try_eval_const
optimization for delete was lost.
https://github.com/datafuselabs/databend/blob/v1.2.592-nightly/src/query/service/src/interpreters/interpreter_delete.rs#L220-L229
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Performance Test (Databend Cloud) (TPC-H SF10)
Databend Cloud (Small)
Update Duration: 94.6s → 29.4s (321%)
Delete Duration: 80.7s → 16.3s (495%)
Databend Cloud (Medium)
Update Duration: 70.2s → 24.6s (285%)
Delete Duration: 64.8s → 8.5s (762%)
Full Test Script
Tests
Type of change
This change is