-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): refactor recluster #16070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Jul 17, 2024
zhyass
force-pushed
the
feature_cluster_table
branch
2 times, most recently
from
July 18, 2024 08:09
9ef127d
to
da8fcef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
How much faster is the new recluster than the old? |
zhyass
added
ci-cloud
Build docker image for cloud test
and removed
ci-cloud
Build docker image for cloud test
labels
Jul 18, 2024
This comment was marked as outdated.
This comment was marked as outdated.
zhyass
added
ci-cloud
Build docker image for cloud test
and removed
ci-cloud
Build docker image for cloud test
labels
Jul 18, 2024
The point of this pr is not to increase execution speed. Instead, it modifies some of the logic of compact and recluster. For example, recluster will implicitly execute compact. Compact on a cluster table will directly execute recluster instead of compact+recluster. |
This comment was marked as outdated.
This comment was marked as outdated.
zhyass
force-pushed
the
feature_cluster_table
branch
from
July 18, 2024 15:56
2b533f2
to
c613bd6
Compare
zhang2014
approved these changes
Jul 21, 2024
zhyass
force-pushed
the
feature_cluster_table
branch
from
July 23, 2024 09:29
49cd1da
to
d1b9ab9
Compare
chore: add defensive checks and rename variables for clarity
dantengsky
approved these changes
Jul 24, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-cloud
Build docker image for cloud test
pr-feature
this PR introduces a new feature to the codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR introduces several enhancements and optimizations related to the reclustering process:
Addition of
RelOperator::Recluster
:Optimize Compact Execution:
Segment-level Sorting:
Tests
Type of change
This change is