Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): PartitionsShuffleKind::ConsistentHash support #16094

Merged
merged 2 commits into from
Jul 23, 2024
Merged

feat(query): PartitionsShuffleKind::ConsistentHash support #16094

merged 2 commits into from
Jul 23, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jul 22, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

PartitionsShuffleKind::ConsistentHash support

PartitionsShuffleKind::ConsistentHash has a significant load skew compared to PartitionsShuffleKind::Mod, so we need to figure out when PartitionsShuffleKind::ConsistentHash is better than PartitionsShuffleKind::Mod.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@forsaken628
consistent hash
63d4d7f 
Signed-off-by: coldWater <forsaken628@gmail.com>
@forsaken628
refine
16dc2c8 
Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 22, 2024
@BohuTANG BohuTANG requested a review from zhang2014 July 23, 2024 01:00
zhang2014
zhang2014 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@zhang2014 zhang2014 added this pull request to the merge queue Jul 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 23, 2024
@forsaken628
feat(query): PartitionsShuffleKind::ConsistentHash support (#16094)
49b27d1 
* consistent hash

Signed-off-by: coldWater <forsaken628@gmail.com>

* refine

Signed-off-by: coldWater <forsaken628@gmail.com>

---------

Signed-off-by: coldWater <forsaken628@gmail.com>
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jul 23, 2024
@BohuTANG BohuTANG merged commit 56ce0e1 into databendlabs:main Jul 23, 2024
75 checks passed
@forsaken628 forsaken628 deleted the const-hash branch August 12, 2024 15:05
@sundy-li sundy-li mentioned this pull request Sep 2, 2024
Closed
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forsaken628 @zhang2014 @BohuTANG