Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: explain analyze output partial infos to debug cardinality estimator #16185

Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat: explain analyze output partial infos to debug cardinality estimator #16185

merged 2 commits into from
Aug 6, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Aug 5, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

explain analyze partial will only output infos about real output rows and estimate rows which is helpful to debug the cardinality estimator.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 marked this pull request as draft August 5, 2024 08:55
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 5, 2024
@xudong963 xudong963 marked this pull request as ready for review August 6, 2024 06:34
@xudong963 xudong963 requested review from zhang2014 and Dousir9 August 6, 2024 06:34
Dousir9
Dousir9 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Dousir9 Dousir9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@xudong963 xudong963 added this pull request to the merge queue Aug 6, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Aug 6, 2024
@BohuTANG BohuTANG merged commit 37ec22d into databendlabs:main Aug 6, 2024
72 checks passed
@xudong963 xudong963 deleted the partial_analyze branch August 6, 2024 10:02
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xudong963 @Dousir9 @BohuTANG