refactor: introduce new method accurate_columns_ranges to Table
#16247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
Introduce a new method `accurate_columns_ranges` to the `Table` trait, which returns the "accurate" ranges of the given columns. The bounds of the column ranges are derived from the segment information of the given table, making them tight. However, for string-type columns, the bounds may have been truncated, which is indicated by the `may_be_truncated` field in the `Bound` struct.
dantengsky
force-pushed
the
feat-accurate_columns_ranges
branch
from
96cb50a to
baaa006
Compare
sundy-li
approved these changes
Aug 16, 2024
sundy-li
approved these changes
Aug 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Introduce a new method
accurate_columns_rangesto theTabletrait, which returns the "accurate" ranges of the given columns.The bounds of the column ranges are derived from the segment information of the given table, making them tight. However, for string-type columns, the bounds may have been truncated, which is indicated by the
may_be_truncatedfield in theBoundstruct.accurate_columns_rangesis intended to be used later in the optimization of queries likeSELECT MIN/MAX(col) FROM t.Tests
Type of change
This change is