Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): Support create/drop dictionary ddl. #16280

Merged
merged 33 commits into from
Aug 21, 2024

Conversation

Winnie-Hong0927
Copy link
Contributor

@Winnie-Hong0927 Winnie-Hong0927 commented Aug 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

We implement the logical plan and binder of dictionary, and we can call the interface of meta to create dictionary.
This allows us to execute Dictionary-related SQL statements in MySql.
For example,

  1. CREATE DICTIONARY d(c1 int) PRIMARY KEY c1 SOURCE(mysql(host='localhost' port='3306' username='root' password='1234' db='db1'));
  2. show create dictionary d;
  3. DROP DICTIONARY IF EXISTS d;

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 19, 2024
@b41sh b41sh self-requested a review August 19, 2024 15:00
@Winnie-Hong0927 Winnie-Hong0927 changed the title feat(query): Support create/drop dictionary ddlFeat dict 4 feat(query): Support create/drop dictionary ddl. Aug 20, 2024
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b41sh b41sh requested a review from sundy-li August 20, 2024 14:52
@b41sh b41sh added this pull request to the merge queue Aug 21, 2024
Merged via the queue into databendlabs:main with commit 6d1a7ee Aug 21, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants