Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support vacuum temporary table #16364

Merged
merged 11 commits into from
Sep 3, 2024
Merged

feat: support vacuum temporary table #16364

merged 11 commits into from
Sep 3, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Sep 2, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Support vacuum files of temporary table(Only tested in mysql session).
  2. Fix copied files deduplication error of tmeporary table.
  3. Change some logs from info to debug.
  4. Add system.temporary_tables.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 2, 2024
@SkyFan2002 SkyFan2002 marked this pull request as ready for review September 2, 2024 08:32
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 2, 2024
@dosubot dosubot bot added A-query Area: databend query C-feature Category: feature C-mysql Category: MySQL labels Sep 2, 2024
@SkyFan2002 SkyFan2002 mentioned this pull request Sep 2, 2024
Closed
11 tasks
@BohuTANG
Copy link
Member

BohuTANG commented Sep 2, 2024 •
edited
Loading

@dosu can you help me review this PR?

dantengsky
dantengsky approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me @youngsofun PTAL, thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@BohuTANG BohuTANG merged commit f885364 into databendlabs:main Sep 3, 2024
71 checks passed
TCeason
TCeason reviewed Sep 3, 2024
View reviewed changes
src/query/service/src/sessions/query_ctx.rs
.session
.session_ctx
.get_client_session_id()
.ok_or(ErrorCode::Internal("No client session id".to_string())),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable http SessionType?

@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason left review comments

@BohuTANG BohuTANG BohuTANG left review comments

@dantengsky dantengsky dantengsky approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
A-query Area: databend query C-feature Category: feature C-mysql Category: MySQL lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SkyFan2002 @BohuTANG @dantengsky @TCeason