refactor: Add NameValueApi, simplify virtual column APIs #16398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
134-2-vcolumn
branch
5 times, most recently
from
04b0072 to
6908f0f
Compare
dosubot
bot
added
the
size:XL
NameValueApi is an abstraction of `name->value` metadata operations. virtual column GRUD API can be simplified with these abstractions.
drmingdrmer
force-pushed
the
134-2-vcolumn
branch
from
9b3a53a to
1d05dd7
Compare
BohuTANG
approved these changes
Sep 5, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Add NameValueApi, simplify virtual column APIs
NameValueApi is an abstraction of
name->valuemetadata operations.virtual column GRUD API can be simplified with these abstractions.
Tests
Type of change
Related Issues
This change is