-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): push rank limit into aggregate partial node #16466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Sep 19, 2024
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Sep 19, 2024
dosubot
bot
added
A-query
Area: databend query
C-performance
Category: Performance
labels
Sep 19, 2024
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:XL
This PR changes 500-999 lines, ignoring generated files.
labels
Sep 19, 2024
xudong963
reviewed
Sep 19, 2024
src/query/sql/src/planner/optimizer/rule/rewrite/rule_push_down_limit_aggregate.rs
Outdated
Show resolved
Hide resolved
src/query/sql/src/planner/optimizer/rule/rewrite/rule_push_down_limit_aggregate.rs
Outdated
Show resolved
Hide resolved
Dousir9
reviewed
Sep 19, 2024
src/query/sql/src/planner/optimizer/rule/rewrite/rule_push_down_limit_aggregate.rs
Show resolved
Hide resolved
xudong963
approved these changes
Sep 19, 2024
Dousir9
approved these changes
Sep 19, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query
Area: databend query
C-performance
Category: Performance
lgtm
This PR has been approved by a maintainer
pr-feature
this PR introduces a new feature to the codebase
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This pr pushes rank limit into aggregate partial node.
For example:
As the group keys may have high cardinality, the HT will resize multiple times to hold the coming keys which is inefficient.
Now we will filter group keys using partial sort with
LimitType::Rank(n)
to keep top n unique keys.So we inject a
SortPartialTransform
before partial agg now.Performance in my PC is 2.8 sec --> 0.35 sec.
Tests
Type of change
This change is