Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): inverted index use merge io to read data #16589

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Oct 10, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Use merge io to read inverted index data, since the term data of the inverted index is relatively small, usually only tens to thousands of bytes, merge io can effectively reducing IO times.
  • refactor merge io and related codes to the common io package, easy for code reuse.

continue #16547

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Code refactoring, using existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and dantengsky October 10, 2024 08:12
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 10, 2024
@b41sh b41sh marked this pull request as ready for review October 10, 2024 09:56
@dantengsky dantengsky added the ci-benchmark Benchmark: run all test label Oct 10, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-16589-8a91f69-1728556727

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG merged commit e7fcde8 into databendlabs:main Oct 12, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants