Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: display port number on error from bind to port failure #16695

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore: display port number on error from bind to port failure #16695

merged 1 commit into from
Oct 28, 2024

Conversation

lyang24
Copy link
Contributor

@lyang24 lyang24 commented Oct 27, 2024 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

display port number on error from bind to port failure

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why simple change add more info to err display

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): error msg enhancement

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 27, 2024
@lyang24 lyang24 force-pushed the display_port_addr_on_listen_failure branch from a011024 to b1e931c Compare October 27, 2024 21:36
@lyang24 lyang24 marked this pull request as ready for review October 28, 2024 04:11
BohuTANG
BohuTANG approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit b7a2969 into databendlabs:main Oct 28, 2024
81 checks passed
@BohuTANG
Copy link
Member

@lyang24 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: The specific port that cannot be listen is displayed
2 participants
@lyang24 @BohuTANG