Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster): fix the possibility of connection leak when the cluster state is broken. #16842

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Nov 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(cluster): fix the possibility of connection leak when the cluster state is broken.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Almost impossible state (caused by bugs during the development process)

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhang2014 zhang2014 requested a review from dqhl76 November 14, 2024 10:50
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 14, 2024
Copy link

what-the-diff bot commented Nov 14, 2024

PR Summary

  • Enhanced Error Handling in Pipeline Building
    The error management process in building distributed pipelines was overhauled. This change propagates errors more effectively, leading to smoother operations and quicker identification of issues.

  • Updated "on finished query" Calls
    Updates were made to the calls to the "on finished query", enabling improved error reporting. This means any issues that occur will be documented more effectively, facilitating quicker fixes.

  • Adaptable Shutdown Query Function
    The function to shut down queries was updated to accept possible errors. This recognition enables the shutdown program to identify the cause for any failures, leading to more effective troubleshooting.

  • Flight Actions Sturdier Against Errors
    The error handling when initiating query environments and fragments, as well as starting prepared queries have been improved. It enables the system to report errors back to the Data Exchange Manager, again aiding troubleshooting and ensuring smoother operations.

  • Logging and Shutdown Logic Adjustments in Exchange Manager
    Minor adjustments made to the logging and shutdown procedures in the Exchange Manager reflect the new robust error handling strategies. These adjustments improve the robustness of the system overall.

Copy link
Collaborator

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhang2014 zhang2014 enabled auto-merge November 14, 2024 11:17
@zhang2014 zhang2014 added this pull request to the merge queue Nov 14, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 14, 2024
@BohuTANG BohuTANG merged commit fea4409 into databendlabs:main Nov 14, 2024
74 checks passed
dantengsky pushed a commit to dantengsky/fuse-query that referenced this pull request Nov 14, 2024
… state is broken. (databendlabs#16842)

* fix(cluster): fix connect leak if server is broken status

* fix(cluster): fix connect leak if server is broken status
dantengsky pushed a commit to dantengsky/fuse-query that referenced this pull request Nov 14, 2024
… state is broken. (databendlabs#16842)

* fix(cluster): fix connect leak if server is broken status

* fix(cluster): fix connect leak if server is broken status
dantengsky added a commit that referenced this pull request Nov 14, 2024
… state is broken. (#16842) (#16845)

* fix(cluster): fix connect leak if server is broken status

* fix(cluster): fix connect leak if server is broken status

Co-authored-by: Winter Zhang <coswde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants