Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StreamVersionMismatched when using CTAS in multi statement trans… #16889

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Nov 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

In the past, the implicit commit of DDLs in multi-statement transactions occurred after the bind phase, which cleared the QueryContext.table_cache. As a result, when the statement was executed, calling get_table() would access the meta service to fetch the latest TableMeta.

However, for some queries, the TableMeta was determined during the bind phase and cached in Metadata.tables, so get_table() was no longer called thereafter. Therefore, this PR moves the implicit commit of DDLs in multi-statement transactions to a point before the bind phase.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 20, 2024
@dantengsky dantengsky added this pull request to the merge queue Nov 21, 2024
@dantengsky dantengsky removed this pull request from the merge queue due to a manual request Nov 21, 2024
@dantengsky dantengsky added this pull request to the merge queue Nov 21, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 21, 2024
@BohuTANG BohuTANG merged commit 1d50bfe into databendlabs:main Nov 21, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants