Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add new raft-log metrics to "metactl status" response #16899

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Nov 21, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: add new raft-log metrics to "metactl status" response

These new metrics are added to gRPC API GetClusterStatus and
corresponding databend-metactl CLI command.

Newly added metrics are:

$ databend-metactl status
# ...
RaftLog:
  - CacheItems: 287
  - CacheUsedSize: 4959439
  - WALTotalSize: 4378076
  - WALOpenChunkSize: 4378058
  - WALOffset: 4378076
  - WALClosedChunkCount: 1
  - WALClosedChunkTotalSize: 18
  - WALClosedChunkSizes:
    - ChunkId(00_000_000_000_000_000_000): 18

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

These new metrics are added to gRPC API `GetClusterStatus` and
corresponding databend-metactl CLI command.

Newly added metrics are:

```
$ databend-metactl status
# ...
RaftLog:
  - CacheItems: 287
  - CacheUsedSize: 4959439
  - WALTotalSize: 4378076
  - WALOpenChunkSize: 4378058
  - WALOffset: 4378076
  - WALClosedChunkCount: 1
  - WALClosedChunkTotalSize: 18
  - WALClosedChunkSizes:
    - ChunkId(00_000_000_000_000_000_000): 18
```
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 21, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review November 21, 2024 04:19
@drmingdrmer drmingdrmer requested a review from everpcpc November 21, 2024 04:19
@drmingdrmer drmingdrmer merged commit 22a8a82 into databendlabs:main Nov 21, 2024
78 checks passed
@drmingdrmer drmingdrmer deleted the 171-raft-stat branch November 21, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants