Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make test_watch_expired_events() less sensitive to inaccurate time #16966

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Nov 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: make test_watch_expired_events() less sensitive to inaccurate time
chore: adjust gRPC logging level
refactor: remove unused sled related config from databend-meta

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 28, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review November 28, 2024 13:05
@drmingdrmer drmingdrmer requested a review from TCeason November 28, 2024 13:19
@drmingdrmer drmingdrmer merged commit 0c3c0e1 into databendlabs:main Nov 28, 2024
72 checks passed
@drmingdrmer drmingdrmer deleted the 179-refactor branch November 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky ci : test_watch_expired_events
1 participant