Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): keep remaining_predicates when filtering grouping sets #16971

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Nov 29, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. keep remaining_predicates when filtering grouping sets
  2. support combined group by expressions, like group by a, rollup(b,c), grouping sets(d, e)
  3. improve "to_string" function for number types.

fixes #16779

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 29, 2024
@TCeason
Copy link
Collaborator

TCeason commented Dec 1, 2024

wait #16980

@sundy-li sundy-li added this pull request to the merge queue Dec 2, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 2, 2024
@BohuTANG BohuTANG merged commit 8466df7 into databendlabs:main Dec 2, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: push_down_filter causes incorrect results
4 participants